7 #183
Closed
7 #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ytify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point of this pr is enable link previews for
https://ytify.netlify.app?s=idon the social medias.The next stage is converting LIT components to Solid-JS. There are advantages to this such as component transparency and reduced complexity in wrapping the components around points of usage. We use Solid-JS simply as a library and not a framework in this case. Our priority is still HTML which is why the
toggle-switchwill continue to be a web component so that it can be written directly in HTML without any JS involved in injecting it.The third stage would be involving breaking down the
fetchListmethod and creating collection item components. The advantages to this is only loading collections on demand and ontolistinstead of their own collapsable children.